Skip to content

fix(js): prevent refreshContainer crash when fields dropdown values mix scalar and array inputs#1206

Merged
stonebuzz merged 3 commits into
mainfrom
fix-fields-refreshContainer-crash
Jun 24, 2026
Merged

fix(js): prevent refreshContainer crash when fields dropdown values mix scalar and array inputs#1206
stonebuzz merged 3 commits into
mainfrom
fix-fields-refreshContainer-crash

Conversation

@Mary-Clb

@Mary-Clb Mary-Clb commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !44474
  • This PR fixes a JavaScript crash in the Fields plugin when refreshContainer() serializes a form containing both a scalar field name and an array field name for the same base key. This was causing the dropdown to stay open even after selecting a new value.
Capture d’écran du 2026-06-04 16-08-32 Capture d’écran du 2026-06-05 09-10-27

@Mary-Clb Mary-Clb self-assigned this Jun 5, 2026
@Mary-Clb Mary-Clb added the bug label Jun 5, 2026
@Mary-Clb Mary-Clb requested review from Rom1-B and stonebuzz June 5, 2026 07:16
@stonebuzz

Copy link
Copy Markdown
Contributor

CAn you validate with customers ? and fix CS

@Rom1-B

Rom1-B commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Fix the CI in a separate PR (the uninstallation step is incomplete)

@Mary-Clb

Mary-Clb commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Waiting for customer approval

@stonebuzz

Copy link
Copy Markdown
Contributor

@Mary-Clb

can you rebase?

@Rom1-B Rom1-B force-pushed the fix-fields-refreshContainer-crash branch from eeeba1c to be5b1d6 Compare June 9, 2026 14:02
@Mary-Clb Mary-Clb force-pushed the fix-fields-refreshContainer-crash branch from be5b1d6 to 4904d24 Compare June 10, 2026 12:41
@stonebuzz stonebuzz merged commit 81e6e2c into main Jun 24, 2026
3 checks passed
@stonebuzz stonebuzz deleted the fix-fields-refreshContainer-crash branch June 24, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants