Skip to content

Remove disabled code #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btry wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −41
Open

Remove disabled code #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions src/Impact/Usage/Boavizta/AbstractAsset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,47 +140,6 @@ protected function query($description): array
return $response;
}

// /**
// * Read the response to find the impacts provided by Boaviztapi
// *
// * @return array
// */
// protected function parseResponse(array $response): array
// {
// $impacts = [];
// $types = Type::getImpactTypes();
// foreach ($response['impacts'] as $type => $impact) {
// if (!in_array($type, $types)) {
// trigger_error(sprintf('Unsupported impact type %s in class %s', $type, __CLASS__));
// continue;
// }
// $impact_id = Type::getImpactId($type);
// if ($impact_id === false) {
// continue;
// }
// $impacts[$impact_id] = $this->parseCriteria($type, $response['impacts'][$type]);

// }

// return $impacts;
// }

// protected function parseCriteria(string $name, array $impact): ?TrackedFloat
// {
// if ($impact['embedded'] === 'not implemented') {
// return null;
// }

// $unit_multiplier = $this->client->getCriteriaUnits()[$name];
// $value = new TrackedFloat(
// $impact['embedded']['value'] * $unit_multiplier,
// null,
// TrackedFloat::DATA_QUALITY_ESTIMATED
// );

// return $value;
// }

public function getEvaluableQuery(string $itemtype, array $crit = [], bool $entity_restrict = true): array
{
$item_table = getTableForItemType($itemtype);
Expand Down