Pin pandas version for Python 3.9 in optional requirements for tests#5219
Closed
Pin pandas version for Python 3.9 in optional requirements for tests#5219
pandas version for Python 3.9 in optional requirements for tests#5219Conversation
gvwilson
approved these changes
Jun 6, 2025
gvwilson
added a commit
that referenced
this pull request
Jun 6, 2025
- Switch to `argparse` and clean up imports in `commands.py`.
- Remove `requires-optional.txt` and `test_requirements/*`
(put dependencies in `pyproject.toml` instead).
- Remove `black` and use `ruff` instead.
- Add `--noformat` option to `python commands.py codegen` for experimenting.
- Pass output directory around to control what is formatted and linted.
- Add `python commands.py format` to only do formatting.
- Add `python commands.py lint` to check code.
- Reformat comments in `codegen/*.py`.
- Use double-quoted strings for (most) code generation.
- Incorporate pandas version pinning from #5219.
Note:
1. Only the generated code is formatted and linted:
- `plotly/validators/**/*.py`
- `plotly/graph_objs/**/*.py`
- `plotly/graph_objects/__init__.py`
2. The strings in the data used by code generation are (for example)
`"'some_name'"` (i.e., have embedded single quotes). This PR does
not try to fix that: instead, we rely on reformatting to turn all
the single-quoted strings into double-quoted strings.
Contributor
Author
|
Pandas team has uploaded wheels for 3.9 which resolves the issue in our pipeline, so I'm closing this PR. @gvwilson You should revert the change in your PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context: pandas-dev/pandas#61563 (comment)
TL;DR Pandas intended to drop support for Python 3.9 in the Pandas 2.3.0 release, and therefore didn’t upload pre-compiled wheels for Python 3.9; however, they forgot to update requires-python in the pyproject.toml, so
uvstill tries to install it and has to compile from scratch since the wheel isn’t available, which fails.This fixes the failing Python 3.9 CI jobs on
main.