fix: Properly include shapes when toggling legend visibility#7813
Merged
Conversation
emilykl
approved these changes
May 29, 2026
Contributor
|
hold up @camdecoster -- any chance the failing image test is related to these changes, since the failure is that some images are not showing up? Maybe shapes and images share some coercion logic. edit: Never mind, unrelated |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include shapes with
legendgroupspecified when handling legend visibility toggling.Closes #6771.
Changes
legend,legendgroupattributesScreenshots/Videos
Before:
Screencast.From.2026-05-28.17-12-40.mp4
After:
Screencast.From.2026-05-28.17-12-04.mp4
Notes
legendgroupand alsoshowlegendasfalsewere getting filtered out of the check for handling legend clicks to toggle visibilityshowlegend, so those attributes weren't getting populatedlegendgroupvisibility toggling