Fix stacked area hide show bug#7668
Merged
Merged
Conversation
camdecoster
approved these changes
Dec 9, 2025
emilykl
force-pushed
the
fix-stacked-area-hide-show-bug
branch
from
December 9, 2025 22:48
bcd7e49 to
44bc554
Compare
Contributor
|
Thank you @emilykl for the fix. |
emilykl
force-pushed
the
fix-stacked-area-hide-show-bug
branch
2 times, most recently
from
January 27, 2026 16:46
44bc554 to
ebbbe38
Compare
Contributor
Author
|
@camdecoster I feel more confident about this fix now. After reviewing the code, I'm satisfied that I think that lines 94-96 in the "before" code were intended to reset these to null as part of the D3 |
…ide/show operations in legend
emilykl
force-pushed
the
fix-stacked-area-hide-show-bug
branch
from
January 30, 2026 17:27
0cd58d1 to
172791d
Compare
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7660
Fixes issue where some traces in stacked area charts were not rendering their fill correctly after certain sequences of hide/show operations in the legend.
Steps to test
Reproduce existing issue
Confirm that this PR fixes the issue
srcwith the build for this branch from the CI: https://output.circle-artifacts.com/output/job/c4caeb45-0a0b-4e23-97b6-ebb26b8561c8/artifacts/0/dist/plotly.js