Handle Decimal in Kaleido JSON serialization#455
Merged
emilykl merged 1 commit intoMay 25, 2026
Conversation
Contributor
Author
|
Local validation after refreshing the branch:
|
emilykl
approved these changes
May 25, 2026
Collaborator
emilykl
left a comment
emilykl
left a comment
There was a problem hiding this comment.
Thanks @Sean-Kenneth-Doherty for this fix! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kaleido's orjson serializer now converts
decimal.Decimalvalues to floats, matching Plotly's JSON encoder behavior. This keeps figures containing Decimal values serializable after the 1.3.0 switch to orjson.Fixes #453
Validation
env TMPDIR=/home/sean/.cache uv run pytest tests/test_kaleido_tab.py tests/test_init.py tests/test_fig_tools.py tests/test_path_tools.py -q -W error: 280 passedenv TMPDIR=/home/sean/.cache uv run ruff check kaleido/_kaleido_tab/_tab.py tests/test_kaleido_tab.py: passedenv TMPDIR=/home/sean/.cache uv run ruff format --check kaleido/_kaleido_tab/_tab.py tests/test_kaleido_tab.py: 2 files already formattedgit diff --check origin/master...HEAD: passed