Handle start_timezone and end_timezone during (de)serialization#2018
Handle start_timezone and end_timezone during (de)serialization#2018davisagli wants to merge 5 commits into
Conversation
|
@davisagli thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Documentation build overview
|
|
@robgietema FYI, we are adding support for serializing and deserializing |
|
@jenkins-plone-org please run jobs |
| deserializer.requested_timezone = data["start_timezone"] | ||
| elif name == "end" and "end_timezone" in data: | ||
| deserializer.requested_timezone = data["end_timezone"] | ||
|
|
There was a problem hiding this comment.
I know that the original issue requests adding timezone serialization for events, but shouldn't we do this for all datetime fields?
There was a problem hiding this comment.
I wouldn't assume that. We've only been thinking about events as we design the solution.
There was a problem hiding this comment.
(I'll keep this in mind, but first I want to make sure everything works end to end with the frontend widgets.)
3 participants
Fixes #1878
📚 Documentation preview 📚: https://plonerestapi--2018.org.readthedocs.build/