Give the two viewers one shared visual language - #8
Open
plearaj wants to merge 1 commit into
Open
Conversation
The flow viewer and the quality report install side by side and render side-by-side artifacts, but only shared a localStorage key. Both now draw from one token set: the same dark/darker/code surface stack, the same warm-paper light theme, one accent, one border/radius/shadow scale, and the same chip, label and button treatments. Design notes: - color-scheme is set per theme in both files, so the report's native <select> controls and both pages' scrollbars follow the page theme. - Real :focus-visible rings on every control in both files. - Severity chips no longer rely on hue alone: high is a solid fill, medium is outlined in its own color, low stays neutral — and each chip names its level in words. Unverified-confidence chips carry a dashed border so provisional findings read as provisional in any palette. - Graph nodes get a per-kind stroke over the per-kind fill, and the legend swatches borrow the same stroke so they match the canvas. - Report line length tightened (880 -> 820), snippets sit on a third code surface inside the site boxes, suggestions separate with a hairline instead of floating. - 32px hit targets on header controls; aria-labels on the viewer's search box and theme toggle. - Light-theme dim/accent tones darkened to hold 4.5:1 on their surfaces; the dark theme's solid high chip keeps ~5.6:1. The honesty surfaces are restyled but unchanged in meaning: coverage still leads and cannot collapse, the no-findings screen stays amber with no pass styling, unreached copy still reads candidate-never- verdict, and findings still render in the JSON's order. No copy changed; both suites pass untouched (249 Python, 33 Node). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A design pass on
templates/shared/viewer.template.htmlandtemplates/shared/report.template.html. Presentation only — no behavior change, no new controls, no dependency.The two files install side by side into
.code-flow/and their outputs land side by side inCode_Flows/, but until now they shared only alocalStoragekey. They now share a token set: a warm paper light theme and a cool slate dark theme, one type scale, one spacing rhythm, one shadow treatment.What did not change
validate()in either file, and neither sentinel moved — verified: zero lines matching the validator's own patterns appear in the diff."__FLOW" + "_DATA__"reassembly.http://occurrences are the two SVG XML namespaces, which is whattest_scaffold_is_self_containedexcises.innerHTMLappears only as= "".Accessibility
color-schemeis now set in both files, closing a minor from the Phase 3b final review — the report viewer ships the product's only<select>elements, and their popups and the page scrollbars previously rendered in the OS theme rather than the page's.Measured in the browser against real fixture data:
Severity is never carried by hue alone — the chip states
HIGH/MEDIUM/LOWin words at weight 700.Verification
Beyond the suites, the pages were driven in a browser against
examples/sample-report.jsonandexamples/sample-flow.json:offsetHeight > 0), carrying the parser message and the</escaping tip. This is the one thing the suite structurally cannot verify.Screenshots could not be captured. The Browser pane does not composite frames in this environment, so verification was DOM and computed-style level, not pixel level. The repo's mandated pre-publish manual browser pass (
npm run release-check) remains the pixel check and is not satisfied by this PR.Known, not fixed here — both pre-existing
🤖 Generated with Claude Code