Unify tracing on PW_TRACE and wire config tracing (fix #79)#111
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PW_TRACE and PW_TRACING coexisted: the PHPUnit trait read PW_TRACE while PlaywrightConfigBuilder::fromEnv() read PW_TRACING, and the tracingEnabled/traceDir config fields were never consumed at runtime. fromEnv() now reads PW_TRACE only: PW_TRACING is removed since it never had any runtime effect. Config tracing is wired: contexts start tracing on creation and save the trace to traceDir on close. Fixes playwright-php#79
smnandre
force-pushed
the
sa/unify-trace-env
branch
from
July 21, 2026 16:54
a5372cb to
c2440da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PW_TRACEandPW_TRACINGcoexisted: the PHPUnit trait readPW_TRACEwhilePlaywrightConfigBuilder::fromEnv()readPW_TRACING, and the tracingEnabled/traceDir config fields were never consumed at runtime.fromEnv()now readsPW_TRACEonly:PW_TRACINGis removed since it never had any runtime effect.Config tracing is wired: contexts start tracing on creation and save the trace to traceDir on close.
Fixes #79