Skip to content

Fix issue with shallowEquals incorrectly returning too early #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ice1080 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue with shallowEquals incorrectly returning too early #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/lib/src/utils/compare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ type Equalable = {
const propA = objA[key];
const propB = objB[key];
// If the object has an equality operator, use this
if(hasEqualsMethod(propA)) {
return propA.equals(propB);
if (hasEqualsMethod(propA) && !propA.equals(propB)) {
return false
} else if (propA !== propB) {
return false;
}
Expand Down