Migrate to @playcanvas/eslint-config v3 (/javascript)#8843
Draft
kpal81xd wants to merge 1 commit into
Draft
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v3 rollout — playcanvas/eslint-config#48 (Wave 5 — highest blast radius).
What changed
/javascript(=/legacy) subpath export.playcanvasConfig.find(...)definedTags hack with the directimport { esmScriptTags } from '@playcanvas/eslint-config'. The old hack located the config entry carryingjsdoc/check-tag-names, read itsdefinedTags, and re-set the rule to[...new Set([...existingTags, 'range', 'step', 'precision'])]. In v3esmScriptTagsalready includesrange/step/precision, so the rule override now setsdefinedTags: [...new Set([...esmScriptTags, 'alpha', 'beta', 'category', 'import'])]— preserving the shared config's own extra tags that the override would otherwise drop./javascript+/react. The hand-rolled minimaljsxUsesVarsrule was removed sinceeslint-plugin-react(bundled by/react) providesreact/jsx-uses-varsnatively; all repo-specific bits (customexamples/*config-block rules,importOrder, globals,max-len, ignores) are preserved. The config loads and parses cleanly, but/react's recommended ruleset surfaces a large new error volume that still needs tuning — see Lint status. Rule triage for examples/ is still TODO.@playcanvas/eslint-configto3.0.0-beta.6in both the root andexamples/packages.Lint status
Draft — both configs load cleanly (no config-invalid / import / parse crashes).
npm run lint): 6 errors / 3 warnings. Drop-in vs v2; remaining items are pre-existing JSDoc/import strict-mode nits (jsdoc/require-hyphen-before-param-description, one inline@type,import/no-named-as-default).npm run lint): 1830 errors / 0 warnings, dominated by rules newly introduced by/react:react/react-in-jsx-scope(1379 — obsolete under the React 19 JSX transform these examples use),react/prop-types(232), and the stricter legacyimport/extensions(219). These need deliberate config tuning (disablereact-in-jsx-scope/ wire up the jsx-runtime, decide onprop-types, relaximport/extensions), not source fixes.Strict-mode/JSDoc triage tracked in playcanvas/eslint-config#48; not fixed here per the rollout policy.