Skip to content

App layout refactor: Phase 3 - #6600

Open
RobertJoonas wants to merge 16 commits into
layout-refactor-phase-2from
layout-refactor-phase-3
Open

App layout refactor: Phase 3#6600
RobertJoonas wants to merge 16 commits into
layout-refactor-phase-2from
layout-refactor-phase-3

Conversation

@RobertJoonas

@RobertJoonas RobertJoonas commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Changes

See phase 1 PR for full context.

Review recommendations:

  1. Review commit by commit -- I've split each template migration into a separate commit.
  2. Hide whitespace -- whole templates wrapped in Layouts.auth
  • Add a legacy_layout? assign (default true) on the shared root layout. When
    false, the root renders a plain @inner_content instead of going through
    Layouts.legacy — the mechanism for a page to fully own its own layout.
  • New Layouts.auth wraps its content in
    <.app header?={false} footer?={false} global_notices?={false}> directly,
    providing the centered logo/heading/subtitle that the new auth pages need.
  • Removed AuthLayoutContext and ControllerHelpers.render_auth_page — call sites
    just pass legacy_layout?: false alongside their existing assigns.
  • All auth templates wrapped in <Layouts.auth>; deleted the old
    templates/layout/auth.html.heex secondary layout.

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@RobertJoonas
RobertJoonas changed the base branch from master to layout-refactor-phase-2 August 14, 2026 16:50
@RobertJoonas
RobertJoonas requested a review from a team August 14, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant