Validate breakdown API page param to return 400 instead of 500#6520
Open
SAY-5 wants to merge 1 commit into
Open
Validate breakdown API page param to return 400 instead of 500#6520SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
breakdownendpoint readpagewithString.to_integer(Map.get(params, "page", "1")), which raisesArgumentErroron any non-numeric value (page=foo,page=1.5,page=), so the request returned a 500 instead of a client error. It also acceptedpage=0and negatives. This addsvalidate_or_default_page/1mirroring the existingvalidate_or_default_limit/1and moves it into thewithchain, so invalid pages now return a 400. Closes #6500.Tests
Changelog
Documentation
Dark mode