Refactor to pass around metrics with their labels#6445
Draft
apata wants to merge 1 commit into
Draft
Conversation
apata
force-pushed
the
query/explicit-metrics
branch
from
5ce04ec to
571bf46
Compare
apata
added
bug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactors dashboard to pass around metrics around the app not by key only, but by their full name.
Solves the nuisance of picking the right metrics for a particular context and then needing to generate the labels for them after the fact.
We know when we prepare the query for the exit pages report that in this context, visitors means unique exits.
Tests
Changelog
Documentation
Dark mode