Fix staging deployment broken by renamed Azure CLI firewall arguments#911
Merged
Conversation
|
tjementum
force-pushed
the
fix-firewall-az-flags
branch
from
d419a1d to
2814ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The staging deployment fails at the database migration step because the Azure CLI on the GitHub-hosted runner adopted a breaking change that repurposes the
az postgres flexible-server firewall-rulearguments.--namenow identifies the firewall rule instead of the server,--server-nameis the new required argument for the server, and--rule-namewas removed. The cluster firewall script still passed the server via--nameand the rule via--rule-name, so the command aborted with "the following arguments are required: --server-name/-s" before any migration could run.--server-nameand the firewall rule through--namein both the create and delete paths of the cluster firewall scriptChecklist