Update workflow to v5.0.0-beta.24#89
Draft
marcopiraccini wants to merge 1 commit into
Draft
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
a844d2c to
5a4be2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
workflowto5.0.0-beta.24ine2e-v5/. Three substantive changes are needed to keep all e2e suites green.Changes
packages/workflow/plugins/events.ts— lazystep_startedbranch. Beta.21+ defersstep_createdon the inline path and expects the world to atomically create the step row fromstep_started(carryingeventData.input). We doINSERT ... ON CONFLICT DO NOTHING RETURNING id; race losers get 409 ->EntityConflictError->{ type: 'skipped' }.e2e-v5/workflows/{e2e,serde-steps}.ts— drop.jsextension from 3 step-file imports. Upstream regression in@workflow/buildersfast-discovery (still present in beta.24): it doesn't rewrite.js->.tsfor relative imports, so.js-suffixed step imports get silently dropped from the manifest. No-extension imports use the candidate loop and work. Minor deviation from upstream Vercel sources; comment in each file documents it.eslint.config.js— ignoree2e-v{4,5}/next-env.d.ts. Next 16 auto-rewrites these files with double quotes + semicolons, violating project style. The files are annotated as not-to-be-hand-edited.Plus Next 16 / workflow rebuild regenerations:
tsconfig.json,next-env.d.ts,e2e-v4/public/.well-known/workflow/v1/manifest.json, and a newe2e-v5/.gitignorefor/.swc.Follow-up
File upstream at
vercel/workflowfor thefast-discovery.js->.tsregression; revert the import edits when fixed.