Skip to content

Update workflow to v5.0.0-beta.24#89

Draft
marcopiraccini wants to merge 1 commit into
mainfrom
workflow5-beta24
Draft

Update workflow to v5.0.0-beta.24#89
marcopiraccini wants to merge 1 commit into
mainfrom
workflow5-beta24

Conversation

@marcopiraccini

@marcopiraccini marcopiraccini commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Bumps workflow to 5.0.0-beta.24 in e2e-v5/. Three substantive changes are needed to keep all e2e suites green.

Changes

packages/workflow/plugins/events.ts — lazy step_started branch. Beta.21+ defers step_created on the inline path and expects the world to atomically create the step row from step_started (carrying eventData.input). We do INSERT ... ON CONFLICT DO NOTHING RETURNING id; race losers get 409 -> EntityConflictError -> { type: 'skipped' }.

e2e-v5/workflows/{e2e,serde-steps}.ts — drop .js extension from 3 step-file imports. Upstream regression in @workflow/builders fast-discovery (still present in beta.24): it doesn't rewrite .js -> .ts for relative imports, so .js-suffixed step imports get silently dropped from the manifest. No-extension imports use the candidate loop and work. Minor deviation from upstream Vercel sources; comment in each file documents it.

eslint.config.js — ignore e2e-v{4,5}/next-env.d.ts. Next 16 auto-rewrites these files with double quotes + semicolons, violating project style. The files are annotated as not-to-be-hand-edited.

Plus Next 16 / workflow rebuild regenerations: tsconfig.json, next-env.d.ts, e2e-v4/public/.well-known/workflow/v1/manifest.json, and a new e2e-v5/.gitignore for /.swc.

Follow-up

File upstream at vercel/workflow for the fast-discovery .js -> .ts regression; revert the import edits when fixed.

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant