Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE(S):
https://platform9.atlassian.net/browse/INF-2864
SUMMARY
added one hidden flag to skip installer download step.
ISSUE TYPE
IMPACTED FEATURES/COMPONENTS:
prep-node
TESTING DONE
Manual
Tested prep-node with and without
--skip-installer-downloadflagcase one
prep-node --skip-installer-download, but installer is not present in pf9 dirresult --> failing with below logs
case two
prep-node --skip-installer-download, installer is already copied in pf9 dirresult --> node onboarded successfully
case three
natural flow, prep-node without --skip-installer-download flag
result --> node onboarded successfully
Reviewers
/cc @sudhakarg @psarwate