Skip to content

Fix unbound RATE_MB_HR under set -u; drop dead code in helper scripts #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teknogeek0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unbound RATE_MB_HR under set -u; drop dead code in helper scripts #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pgcopydb-helpers/check-cdc-status.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ GAP_GB=""
CAUGHT_UP=""
APPLY_RATE=""
ETA=""
RATE_MB_HR=""
RATE_GB_HR=""

# Get first and last apply lines to compute rate
FIRST_APPLY_LINE=$(grep "Apply reached" "$LOG" 2>/dev/null | head -1 || true)
Expand Down
1 change: 0 additions & 1 deletion pgcopydb-helpers/preflight-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ else
fi

# ── Summary ────────────────────────────────────────────────────────
TOTAL=$((PASS_COUNT + WARN_COUNT + FAIL_COUNT))
echo ""
echo " ══════════════════════════════════════════════════════════════════"
echo -e " Summary: ${GREEN}$PASS_COUNT passed${NC}, ${YELLOW}$WARN_COUNT warnings${NC}, ${RED}$FAIL_COUNT failed${NC}"
Expand Down
6 changes: 0 additions & 6 deletions pgcopydb-helpers/verify-migration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ q() {
psql "$conn" -t -A -F $'\t' -c "$sql" 2>/dev/null | grep -v '^$' || true
}

# Like q() but prints psql errors to stderr so they're visible
q_verbose() {
local conn="$1" sql="$2"
psql "$conn" -t -A -F $'\t' -c "$sql" | grep -v '^$' || true
}

# Count non-empty lines in a variable
# grep -c exits 1 on zero matches (but still prints "0"), so || true is enough
line_count() { printf '%s' "${1:-}" | grep -c . || true; }
Expand Down