config: block credential/endpoint overrides from project .pscale.yml#1307
Draft
mscoutermarsh wants to merge 1 commit into
Draft
config: block credential/endpoint overrides from project .pscale.yml#1307mscoutermarsh wants to merge 1 commit into
mscoutermarsh wants to merge 1 commit into
Conversation
Directory-local .pscale.yml was MergeInConfig'd with no key filter, so a checked-in api-url (or service-token) could redirect authenticated API calls and leak the user's keyring token. Only merge org/database/branch from project/working-directory config; warn when other keys are ignored. Co-authored-by: Mike Coutermarsh <coutermarsh.mike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Project-scoped
.pscale.yml(git root or cwd) was merged into viper with no key filter. A checked-in file could setapi-url,api-token, orservice-token/service-token-id, sopscalewould send the user's keyring OAuth token to an attacker-controlled host.Fix
MergeInConfigfor project files withMergeProjectConfig, which only mergesorg,database, andbranch.api-urland tokens).~/.config/planetscale/pscale.yml),--config, flags, and env vars are unchanged.Tests
api-url/ token keysapi-urland never imports project credentialsgo test ./internal/config/passes.