ci: fix OIDC publish auth (drop registry-url placeholder token) - #5
Merged
Conversation
The previous OIDC attempt still 404'd because actions/setup-node with
registry-url writes an .npmrc with _authToken=${NODE_AUTH_TOKEN} and a
placeholder token, which the publisher used instead of doing the OIDC
exchange. Remove registry-url so nothing shadows OIDC, upgrade to
npm >= 11.5.1 (required for trusted publishing), and publish with npm publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4 — the OIDC publish still failed with
E404.Root cause:
actions/setup-nodewithregistry-urlwrites an.npmrccontaining_authToken=${NODE_AUTH_TOKEN}and defaultsNODE_AUTH_TOKENto a placeholder (XXXXX-XXXXX-XXXXX-XXXXX). The publisher used that fake token instead of the OIDC exchange → 404. Provenance signing worked (it uses the id-token directly), which masked the auth problem.Fix:
registry-urlfromsetup-nodeso no placeholder auth token shadows OIDC.npm@latest(OIDC trusted publishing needs npm ≥ 11.5.1).npm publish(the reference OIDC path) instead ofpnpm publish.Trusted Publisher config is unchanged (same repo +
publish.yml). Merging triggers the workflow, which should publish the next patch version via OIDC.