Copernicus Native OJS 3.5 Plugin - #509
Conversation
|
Hi @arissupriy, Before this can be merged, there's one blocking issue, plus a scope question and several documentation items worth resolving: Blocking: hardcoded write to an external server Every export on any installation running this plugin attempts to write the full exported XML to this hardcoded absolute path. This can't ship in a gallery plugin regardless of intent. Can you please remove this line and explain how it ended up in the release? Scope: this only works for bilingual EN/Indonesian journals Exception handling leaks server internals — and duplicates what core already does This echoes exception details plus full server file paths to the browser. OJS already has a global exception handler (PKPContainer.php) that logs full details via error_log() server-side and never leaks file/line to the client. Simplest fix: drop the try/catch and let it bubble to core's handler; if you want a custom error page, error_log($e->__toString()) then show a generic translated message — no exception internals in the response. Output doesn't fully conform to the ICI import schema
plugins.xml entry
Happy to review it again, once the major points are updated/fixed. |
No description provided.