Allow multi-version openssl/abseil alongside unicode

[jhheider]

Generalize the unicode.org hydrate special-case so parallel-installable
ABI lines (openssl 1.1 vs 3, abseil LTS namespaces) can coexist in one
graph instead of failing constraint intersection.

[Copilot]

Pull request overview

This PR generalizes hydrate’s previous unicode.org-only special-case into a reusable mechanism for “parallel-installable” projects (eg ICU majors, OpenSSL sonames, Abseil LTS namespaces), so non-intersecting constraints can coexist rather than failing resolution.

Changes:

• Introduces a MULTI_VERSION_PROJECTS allowlist plus helpers to collect additional non-intersecting constraints.
• Updates hydrate() and condense() to preserve multiple constraints for allowlisted projects (and to return errors instead of panicking on non-allowlisted non-intersections).
• Adds unit tests covering unicode/openssl/abseil multi-version hydration scenarios.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

crates/lib/src/hydrate.rs:13

• The comment says we “keep multiple nodes” when constraints can’t intersect, but the implementation still keeps a single graph node per project (keyed by project name) and records extra ABI lines as additional PackageReq entries. This mismatch can mislead future changes (eg expecting multiple graph nodes/parents to exist).

/// Projects whose distinct version lines are parallel-installable (different
/// sonames / ICU majors / abseil LTS namespaces). When constraints cannot
/// intersect we keep multiple nodes instead of failing the graph.
///
/// - unicode.org: ICU major ABI (see pantry#4104, pkgx#899)
/// - openssl.org: libssl.so.1.1 vs libssl.so.3
/// - abseil.io: LTS inline-namespace + soversion (20250127 vs 20250512, …)
const MULTI_VERSION_PROJECTS: &[&str] = &["unicode.org", "openssl.org", "abseil.io"];

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

[coveralls]

Coverage is 90.131% — multi-version-abi-coexistence into main. No base build found for main.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

crates/lib/src/sync.rs:43

• Using Err("…")?; as a statement is likely to trigger clippy::needless_question_mark (and this repo runs cargo clippy with -D warnings). Prefer an explicit early-return with Err(... .into()) to avoid CI failures and make control-flow clearer.

        } else {
            Err("PKGX_PANTRY_DIR is set but does not contain a pantry (missing projects/)")?;
        }

crates/cli/src/resolve.rs:92

• Using Err("…")?; here is likely to trip clippy::needless_question_mark (CI runs clippy with -D warnings). Use an explicit return Err(... .into()); so this branch is clearly an early-exit and won’t fail linting.

    if !resolution.pending.is_empty() {
        if env::var("PKGX_NO_INSTALL").is_ok() {
            Err("PKGX_NO_INSTALL is set, refusing to install pending packages")?;
        }
        let installed = install_multi(&resolution.pending, config, spinner.arc()).await?;

.github/workflows/ci.yml:76

• This adds a Homebrew brew trust invocation, but the workflow doesn’t otherwise use Homebrew to install Coveralls tooling. This extra step can introduce avoidable failures on macOS runners (eg if the runner’s Homebrew version doesn’t include trust). If this is intended as a best-effort workaround, guard it so it won’t break CI when unavailable.

      - run: brew trust coverallsapp/coveralls
        if: matrix.os == 'macos-latest'

.github/workflows/ci.yml:240

• Same as above: the unconditional brew trust call on macOS can make this job fragile if the runner’s Homebrew doesn’t support trust, and it’s not otherwise used in this workflow. Consider guarding it so the step becomes a no-op when unavailable.

      - run: brew trust coverallsapp/coveralls
        if: matrix.os == 'macos-latest'

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.