fix(pnpm): pin Node dep, switch to npm version source#12160
Open
timothytlewis wants to merge 1 commit intomainfrom
Open
fix(pnpm): pin Node dep, switch to npm version source#12160timothytlewis wants to merge 1 commit intomainfrom
timothytlewis wants to merge 1 commit intomainfrom
Conversation
…rove tests
- Change version source from github tags to npm registry for more
reliable version tracking
- Pin nodejs.org dependency to ^18 || ^20 || ^22 (pnpm 9+ requires
Node 18+) instead of permissive wildcard '*'
- Add version verification test (pnpm --version | grep {{version}})
alongside existing pnpm doctor check
- Convert build script from block scalar to plain scalar style
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jhheider
reviewed
Mar 6, 2026
|
|
||
| dependencies: | ||
| nodejs.org: '*' | ||
| nodejs.org: ^18 || ^20 || ^22 |
Contributor
There was a problem hiding this comment.
this will break older pnpms working with older nodes, as well as pnpm working with newer nodes.
jhheider
reviewed
Mar 6, 2026
|
|
||
| build: | ||
| script: | | ||
| script: |
Contributor
There was a problem hiding this comment.
this change breaks the (string-style) script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github: pnpm/pnpmtonpm: pnpmto avoid needing the pre-release ignore regexnodejs.orgdependency from*to^18 || ^20 || ^22matching pnpm's supported Node.js versionspnpm --versiontest for version verificationscript: |→script:list formTest plan
bk build pnpm.io— passesbk audit pnpm.io— passesbk test pnpm.io— passes🤖 Generated with Claude Code