Stop capfire from altering the repository variable#4
Open
bdurand wants to merge 1 commit intopjaspers:masterfrom
weheartit:master
Open
Stop capfire from altering the repository variable#4bdurand wants to merge 1 commit intopjaspers:masterfrom weheartit:master
bdurand wants to merge 1 commit intopjaspers:masterfrom
weheartit:master
Conversation
|
If you are still interested in not altering the repository variable I have made few changes in capfire and forked it. I have also written tests and made few other interesting changes. You can found it here: https://github.com/RaVbaker/capfire/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where capfire calls the destructive gsub! method on the repository variable to turn it from a git URL into an http URL. This changes the value for all capistrano tasks, not just capfire which can cause subsequent tasks to fail.