Cache plan preview repository routing - #7088
Open
rootp1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: rootp1 <arnav.iitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked Issue
Fixes #7087
What Changed
RequestPlanPreviewrouting matchespipedStore.ListVerification
go test ./pkg/app/server/grpcapi -run 'TestRequestPlanPreview|TestRequireAPIKey'— passedgo test -bench BenchmarkRequestPlanPreviewRepositoryRouting -benchmem ./pkg/app/server/grpcapi— passedmake build/go— passedmake check/gen/code— passedmake check— not passed:lint/gouses a pinnedgolangci-lintimage built with Go 1.25, but this repository targets Go 1.26.2, so lint fails before the rest ofmake checkcan completemake check/dco— not passed: fails on upstream commit25ae69937e55e8330bff96c34346718f3e5e7148, which is already contained inupstream/masterScope
What this PR does:
Caches repository routing for plan preview requests so repeated requests do not rescan every active piped in the project.
Why we need it:
Plan preview is an interactive path, and repeated requests for the same repository and branch should not require a full active-piped scan each time.
Which issue(s) this PR fixes:
Fixes #7087
Does this PR introduce a user-facing change?: