Limit filtered deployment pages to request size - #7075
Open
rootp1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: rootp1 <arnav.iitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
ListDeploymentsresponses to the requested filtered page size when label filters are appliedWhy we need it:
Which issue(s) this PR fixes:
Fixes #7074
Does this PR introduce a user-facing change?:
Summary
WebAPI.ListDeploymentsgrpcapiregression testsLinked Issue
Fixes #7074
What Changed
ListDeploymentsfiltered pagination resumesPageSizeVerification
go test ./pkg/app/server/grpcapi -run 'TestListDeploymentsWithLabels'— passedcd pkg/app/server/grpcapi && /Users/rootp1/go/bin/golangci-lint run -v --config /Users/rootp1/Documents/repos/n/new/pipecd-issue2/.golangci.yml ./...— passedmake update/web-deps— passedmake check— failed: repository-pinnedgolangci-lintimage is built with Go 1.25.0 while this repo targets Go 1.26.2, so lint aborts before analysis/Users/rootp1/go/bin/golangci-lint run -v --config .golangci.ymlacross repo modules — failed: unrelated existinggoheaderissue inweb/node_modules/flatted/golang/pkg/flatted/flatted.goafter installing web dependenciesmake check/gen/code— passedmake check/dco— failed: existing upstream commit25ae69937e55e8330bff96c34346718f3e5e7148is missing aSigned-off-bylinemake test— not completed: rootgo test -failfast -race ./pkg/... ./cmd/...remained running without further output for several minutes on this machine and was stopped after targeted checks had already passedScope
pkg/app/server/grpcapi/web_api.goandpkg/app/server/grpcapi/web_api_test.gowere changed for this fix