fix: prevent nil-deref panic on invalid pem block (#7053) - #7054
Open
oindrilakha12-ui wants to merge 1 commit into
Open
fix: prevent nil-deref panic on invalid pem block (#7053)#7054oindrilakha12-ui wants to merge 1 commit into
oindrilakha12-ui wants to merge 1 commit into
Conversation
Signed-off-by: Oindrila Khan <oindrilakha12@gmail.com>
oindrilakha12-ui
force-pushed
the
fix/issue-7053
branch
from
July 21, 2026 15:40
6d9d5d1 to
daccb61
Compare
Contributor
Author
|
@Warashi , @rahulshendre please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a nil check for the decoded PEM block in
ParseRSAPublicKeyFromPemandParseRSAPrivateKeyFromPem(insidepkg/crypto/key.go) to safely return an error instead of crashing.Why we need it:
When
pem.Decodereceives invalid or non-PEM data, it returns anilblock. Accessingblock.Byteswithout checking causes a process crash. This fixes a potential Denial of Service (DoS) vulnerability.Which issue(s) this PR fixes:
Fixes #7053
Does this PR introduce a user-facing change?:
No.