Fetch all pages in piped ListApplications - #7052
Open
rootp1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: rootp1 <arnav.iitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Summary
PipedAPI.ListApplicationsinternally until the datastore cursor is exhaustedWhy we need it:
PipedAPI.ListApplicationscurrently returns only the first datastore page and silently drops additional applications when a piped manages more than one page of apps.Which issue(s) this PR fixes:
Fixes #7051
What Changed
applicationStore.Listcall inpkg/app/server/grpcapi/piped_api.gowith an internal loop over datastore cursorsTestPipedAPIListApplicationsFetchesAllPagesinpkg/app/server/grpcapi/piped_api_test.goVerification
go test ./pkg/app/server/grpcapi -run TestPipedAPIListApplicationsFetchesAllPages— passedgo test ./pkg/app/server/grpcapi— passed$(go env GOPATH)/bin/golangci-lint run --config .golangci.yml ./pkg/app/server/grpcapi/...— passedmake check/gen/code— passedmake check— failed: repository lint step usesgolangci-lintv2.4.0 built with Go 1.25, but this repository targets Go 1.26.2, so lint aborts before the test phase./hack/ensure-dco.sh— failed: reports pre-existing commit25ae69937e55e8330bff96c34346718f3e5e7148missingSigned-off-by; new commit5430db3949cb1ef3a5bdb90608629f90e44e24ebis signed offScope
Does this PR introduce a user-facing change?: