[Multi_K8s-Plugin] Fix Rollback Variant Cleanup #6660
Open
mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
Open
[Multi_K8s-Plugin] Fix Rollback Variant Cleanup #6660mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
Conversation
…variants Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Contributor
Author
|
@khanhtc1202 @Warashi Please take a look when less busy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enhances the
K8S_MULTI_ROLLBACKstage in thekubernetes_multiclusterplugin to delete leftover CANARY and BASELINE variant resources after restoring the previous deployment manifests.Why we need it:
When a pipeline fails mid-way (e.g., after
K8S_CANARY_ROLLOUTbut beforeK8S_CANARY_CLEAN), the rollback stage was triggered but left orphaned canary/baseline pods running in the cluster indefinitely. This fix ensures the cluster is fully cleaned up on rollback.Which issue(s) this PR fixes:
Fixes #6446
Does this PR introduce a user-facing change?: