Open
Conversation
- Remove --services CLI flag and service validation from cmd/export.go - Remove service: davinci from all 8 YAML definition metadata sections - Move environment.yaml to definitions/pingone/base/ (subdirs are organizational only) - Flatten Go handlers from internal/platform/pingone/davinci/ to internal/platform/pingone/ - Remove Service() from APIClient interface and ListByService from registry - Update embed glob to cover all pingone subdirectories - Update LoadFromFS root from pingone/davinci to pingone - Remove Service field from all test metadata structs - Update documentation (README, ARCHITECTURE, DEVELOPER_HANDBOOK, schema README)
Checkout agent configuration files from agentic-development-files branch.
- Add compare package extensions: CompareHCLGeneric (all block types + tfvars), CompareJSON (Terraform JSON), CompareDirectories (recursive directory walker), severity classification (additions=acceptable, deletions/modifications=breaking) - Add regression-compare CLI tool (tools/regression-compare/) with human-readable summary + JSON report output, exit 0/1/2 semantics - Add GitHub Actions workflow (.github/workflows/regression.yaml) that builds binaries from both base and PR branches, runs matrix of export flag combinations against a static PingOne environment, compares outputs, posts PR comment summary - Add flag combination matrix (tests/regression/matrix.json) with 6 entries covering HCL and tfjson formats with varying dependency/import settings - Add regression-local Makefile target using git worktree to build base branch binary for true base-vs-current comparison (not idempotency test) - Add regression testing documentation (tests/regression/README.md)
…rces, and --list-resources flags\n\nPhase 1 MVP of pattern-based resource selection:\n- New internal/filter package with glob and regex (regex: prefix) pattern matching\n- Case-insensitive matching against full resource address (resource_type.terraform_label)\n- Filter applied in orchestrator after label assignment, before graph population\n- Excluded resources never enter dependency graph (references fall back to var. refs)\n- Schema-driven dependency warnings when referenced types are excluded\n- --list-resources prints all resource addresses and exits\n- Multiple patterns combine via OR; no flags = export all (backwards compatible)\n- 74 filter unit tests + 8 orchestrator integration tests"
… filter variables, remove skip-imports) Bug 1: Add nil_value schema field with keep_empty option. When API returns nil for console_url on pingone_environment, emit empty string instead of omitting — prevents Terraform plan diff after import. Bug 2: Only emit secure: false in custom_auth nested properties when the API actually includes the secure key. Prevents plan diff on pingone_davinci_connector_instance. Bug 3: Inject raw environment UUID for pingone_environment reference attributes when --skip-dependencies is active, even for definitions without source_path. Bug 4: Filter-excluded upstream resources now produce unique variable names derived from the resource label (e.g., var.pingone_davinci_application_pingcli__my_app_id). Environment refs keep the canonical pingone_environment_id name. Fallback variable declarations are collected and written to variables.tf. Bug 5: Remove unused --skip-imports flag (--include-imports is the active control)."
Remove skip-imports references from regression.yaml and matrix.json to match the --skip-imports flag removal from the CLI."
Regression Test Results
❌ Regressions detectedOne or more export configurations produced breaking changes. Breaking change details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.