fix(desktop): stop spellcheck underlines on the composer - #7866
fix(desktop): stop spellcheck underlines on the composer#7866Exotic209093 wants to merge 1 commit into
Conversation
The desktop composer inherits Chromium spellcheck, whose dictionaries come from the OS locale only. The app has no UI-language setting to derive dictionaries from, so text in any other language is underlined as misspelled. Opt the composer out of spellcheck like every other input in the app already does. ox-alpha via opencode
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a simple UI adjustment that disables spellcheck underlining on the composer input, matching existing patterns in the codebase. The change has no runtime behavior impact beyond visual presentation. You can add or adjust custom eligibility rules. Learn more. |
Problem
The desktop composer inherits Chromium spellcheck, whose dictionary list is populated from the OS locale only (and an empty list falls back to
en-US). T3 Code has no UI-language setting the dictionaries could be derived from, so any text typed in a language other than the OS locale gets underlined as misspelled (#7742).Fix
Opt the composer's contenteditable out of spellcheck (
spellCheck={false}). This matches existing precedent in the repo: every other input and textarea already passesspellCheck={false}, the mobile terminal input setsspellCheckingType = .no, and #2554 was previously closed as "composer disables spellcheck". One prop fixes both the desktop shell and any browser loading the same web client, without inventing new settings machinery or touching Electron internals.A dictionary picker / spellcheck toggle would be a bigger product decision; happy to split that out if wanted.
Fixes #7742
ox-alpha via opencode
Note
Low Risk
Tiny UI-only prop change on the composer; no auth, data, or editor logic impact.
Overview
Disables Chromium spellcheck on the composer
ContentEditableso non-OS-locale text is no longer underlined as misspelled.Sets
spellCheck={false}on the prompt editor, matching other inputs in the app. There is no UI-language setting to drive dictionaries, so this is a one-prop opt-out rather than a new toggle.Reviewed by Cursor Bugbot for commit 2d68318. Configure here.
Note
Disable spellcheck on
ContentEditableinComposerPromptEditorInnerSets
spellCheck={false}on theContentEditableelement in ComposerPromptEditor.tsx to stop browser spellcheck underlines. The app currently lacks a UI-language concept, making the default spellchecker inaccurate.Macroscope summarized 2d68318.