Skip to content

fix(web): support Ctrl+V terminal paste on Windows - #7850

Open
alguiraud wants to merge 1 commit into
pingdotgg:mainfrom
alguiraud:fix/windows-terminal-paste
Open

fix(web): support Ctrl+V terminal paste on Windows#7850
alguiraud wants to merge 1 commit into
pingdotgg:mainfrom
alguiraud:fix/windows-terminal-paste

Conversation

@alguiraud

@alguiraud alguiraud commented Aug 21, 2026

Copy link
Copy Markdown

What Changed

Added Windows-specific terminal paste handling so Ctrl+V triggers clipboard paste.

Why

(This may have been on purpose for Windows so feel free to disregard)

When using WSL from Windows Terminal, Ctrl+V is handled by the Windows terminal as paste before the key reaches Linux. T3’s Windows client should provide the same behavior to avoid friction.

Previously, Windows fell into the generic non-macOS path, so Ctrl+V was forwarded to the WSL PTY as control-V and appeared as ^V.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Small, well-tested shortcut mapping change with no auth or data-handling impact. Linux still keeps Ctrl+V for the PTY.

Overview
Treats Ctrl+V as clipboard paste on Windows in isTerminalPasteShortcut, instead of the previous non-mac path that required Ctrl+Shift+V and forwarded Ctrl+V as ^V.

macOS stays Cmd+V; Linux still uses Ctrl+Shift+V so Ctrl+V can reach the PTY. Adds a Windows unit test.

Reviewed by Cursor Bugbot for commit 9a8962d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Support Ctrl+V terminal paste on Windows in isTerminalPasteShortcut

  • Updates the v key branch of isTerminalPasteShortcut in surface.ts to return true for Ctrl+V on Windows.
  • macOS keeps Cmd+V, and other non-mac platforms keep Ctrl+Shift+V.
  • Adds a test case in surface.test.ts confirming Windows uses Ctrl+V (not Cmd+V).
  • Risk: Windows users who relied on Ctrl+Shift+V now trigger paste with plain Ctrl+V via isTerminalPasteShortcut, which may conflict with existing Ctrl+V bindings in the terminal surface.

Macroscope summarized 9a8962d.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 21, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 9a8962d

Macroscope's review found this PR approvable — Straightforward bug fix that adds Windows-specific handling for Ctrl+V paste in the terminal, matching expected OS behavior. The change is small, well-scoped, and includes a unit test.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 35473442-5cbb-438b-9681-34da843de09c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant