fix(web): keep grouped project renames - #7831
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad191f0. Configure here.
…ngs-group-rename-conflict # Conflicts: # apps/web/src/components/settings/ProjectSettingsPanel.tsx
ApprovabilityVerdict: Skipped Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically. |

Problem
Project settings compared a requested group title with
group.displayName. That label can come from repository metadata when checkout titles differ, so a valid rename could return before sending any update.Fix
Treat the rename as a no-op only when every stored member title already matches the requested title. Add focused coverage for divergent and converged project groups.
Tests
vp test run apps/web/src/components/settings/ProjectSettingsPanel.logic.test.ts packages/client-runtime/src/state/projectGrouping.test.tsvp lint apps/web/src/components/settings/ProjectSettingsPanel.tsx apps/web/src/components/settings/ProjectSettingsPanel.logic.ts apps/web/src/components/settings/ProjectSettingsPanel.logic.test.tsvp run -F @t3tools/web typecheckCloses #7510
Built with gpt-5.6-sol through the Codex harness in T3 Code.
Note
Low Risk
Narrow UI rename-guard change with unit tests; no auth or data-model changes beyond existing project title updates.
Overview
Fixes grouped project rename in settings so a valid name is no longer dropped when it matches the derived
displayNamebut member titles still differ.renameGroupnow usesprojectGroupTitleNeedsUpdate: it writes only if the user actually edited the field and at least one member title differs from the requested name. Untouched blur (including when the shown label is a repo-derived name) is a no-op. Adds unit coverage for those cases.Reviewed by Cursor Bugbot for commit 95b5b83. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix grouped project renames to only trigger on actual edits
projectGroupTitleNeedsUpdateutil in ProjectSettingsPanel.logic.ts that returns true only when the input was edited and at least one member title differs from the target title.ProjectDetailin ProjectSettingsPanel.tsx to track edit state via a ref (projectNameEditedRef) and pass awasEditedflag torenameGroup.group.displayNameand per-member titles) with a single call to the new util.Macroscope summarized 95b5b83.