Skip to content

fix(mobile): derive newThreadTarget from full thread history, not search matches #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
t3dotgg wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Draft

fix(mobile): derive newThreadTarget from full thread history, not search matches #3693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions apps/mobile/src/features/home/homeThreadList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,15 @@ export function buildHomeThreadGroups(input: {
: sortedThreads;

// Sorted newest-first, so the first thread whose project is a group member
// marks the machine the user last worked on.
const lastActiveProject = Arr.findFirst(sortedThreads, (thread) =>
group.projects.some(
(project) =>
project.environmentId === thread.environmentId && project.id === thread.projectId,
),
// marks the machine the user last worked on. Derived from the FULL history
// (not the search-filtered subset) so the target is stable across queries.
const lastActiveProject = Arr.findFirst(
sortThreads(group.threads, input.threadSortOrder),
(thread) =>
group.projects.some(
(project) =>
project.environmentId === thread.environmentId && project.id === thread.projectId,
),
).pipe(
Option.flatMap((thread) =>
Arr.findFirst(
Expand Down
Loading