Use idiomatic Effect patterns in diagnostics#2762
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Schema.fromJsonStringdecoders andOptionhelpers instead ofJSON.parseand null sentinels.Durationfor query timeout policy, Schema decoding for Windows process JSON, granular tagged errors, andLayer.mock/assertin tests.Why
These changes make the diagnostics code easier to test and maintain with Effect-native primitives while keeping the existing runtime behavior and service boundaries focused.
UI Changes
Not applicable.
Checklist
Note
Refactor diagnostics to use idiomatic Effect patterns with structured errors and schema decoding
ProcessDiagnosticsErrorwith a tagged union of specific error types (ProcessQueryError,ProcessQueryTimeoutError,ProcessCommandExitError,ProcessSignalRejectedError,ProcessSignalFailedError), each with structured fields.WindowsProcessRowSchemaand schema-driven JSON decoding in ProcessDiagnostics.ts, replacing rawJSON.parse; invalid entries are skipped and decode failures return[].effect/Schemafor trace line decoding andOption-based helpers instead of null-returning utilities.PROCESS_QUERY_TIMEOUT_MSfrom a numeric millisecond constant to aDurationvalue.ProcessQueryTimeoutErrorwithtimeoutMillis; non-zero process exit now emitsProcessCommandExitErrorwithcommand,exitCode, andstderr.Macroscope summarized bed9031.