Clear stale provider update toast CTA#2755
Draft
jeremy0dell wants to merge 1 commit into
Draft
Conversation
- Factor toast update construction into shared logic - Remove prompt actions from loading and success update states - Keep rejected update states actionable via Settings
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Base UI shallow-merges toast updates. The initial provider update prompt sets the primary CTA to
Update, and the running toast update previously omittedactionProps, so the old CTA remained visible on theUpdating providerstoast.Validation
bun run testbun fmtbun lintbun typecheckNote
Clear stale action buttons from provider update toast on progress and success
buildProviderUpdateToastUpdateinProviderUpdateLaunchNotification.logic.tsto centralize toast update construction for provider update views.actionProps: undefinedexplicitly to clear any action buttons (e.g. 'Update') left over from a previously shown prompt toast, working around shallow merge behavior in the toast manager.updateProviderUpdateToastinProviderUpdateLaunchNotification.tsxto call the new helper instead of duplicating inline logic.Macroscope summarized edad6db.