Skip to content

Skip a unit test that is using a bash script on Windows#1490

Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom
Alexx999:pr-windows-test
Mar 28, 2026
Merged

Skip a unit test that is using a bash script on Windows#1490
juliusmarminge merged 1 commit intopingdotgg:mainfrom
Alexx999:pr-windows-test

Conversation

@Alexx999
Copy link
Copy Markdown
Contributor

@Alexx999 Alexx999 commented Mar 28, 2026

What Changed

Skip PATH inheritance unit test on Windows

Why

It's using a bash script and that won't work on win32

Checklist

  • This PR is small and focused
  • I explained what changed and why

Note

Low Risk
Low risk: only changes test execution by skipping a bash-script-based unit test on Windows, with no production code impact.

Overview
Updates ProviderRegistry.test.ts to skip on Windows the checkCodexProviderStatus PATH-inheritance test that writes/executes a #!/bin/sh mock codex binary, preventing win32 CI failures while keeping the test behavior unchanged on non-Windows platforms.

Written by Cursor Bugbot for commit af5b0b0. This will update automatically on new commits. Configure here.

Note

Skip bash-dependent checkCodexProviderStatus test on Windows

The test "inherits PATH when launching the codex probe with a CODEX_HOME override" in ProviderRegistry.test.ts uses a bash script incompatible with Windows. Replaces it.effect(...) with it.effect.skipIf(process.platform === "win32")(...) to skip execution on Windows while leaving the test body unchanged.

Macroscope summarized af5b0b0.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 28, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ac3bb80c-f390-47f9-a740-2692e2495f1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 28, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@github-actions github-actions bot added size:L 100-499 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Mar 28, 2026
@juliusmarminge juliusmarminge merged commit d2e6c82 into pingdotgg:main Mar 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants