fix(web): compact chat header actions into an overflow menu#1485
fix(web): compact chat header actions into an overflow menu#1485inj-src wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| })} | ||
| </> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Dialogs missing when git actions rendered in menu mode
High Severity
The inMenu render path returns early with only the menu items, but both the commit Dialog and the default-branch confirmation Dialog are only rendered in the non-inMenu return block further below. Clicking "Commit" in the overflow menu calls setIsCommitDialogOpen(true) via openDialogForMenuItem, but the dialog JSX is never mounted so nothing appears. Similarly, push/PR actions on a default branch silently set pendingDefaultBranchAction state with no confirmation dialog ever rendering, causing the action to be silently dropped.


Summary
Verification
Note
Low Risk
Primarily UI/layout refactoring in the chat header plus a new
GitActionsControlmenu-rendering mode; risk is limited to potential regressions in header action availability/disabled states at different widths.Overview
Chat header actions are now responsive. When the header is narrower than a fixed breakpoint, project scripts, “open folder”, and git actions move into an
…overflow menu while the terminal/diff toggles remain pinned.GitActionsControlgains a menu-only render path. A newinMenuprop lets the component emitMenuItems (including disabled-state tooltips) so the same git workflows can be reused inside the new overflow menu.Written by Cursor Bugbot for commit 496fde5. This will update automatically on new commits. Configure here.
Note
Collapse chat header actions into an overflow menu below 860px width
ResizeObserverto toggle a compact mode when the container is narrower than 860px, replacing inline controls with a 'More actions' menu.inMenuprop onGitActionsControl.inMenuprop that renders Git actions asMenuItementries with popover tooltips for disabled items instead of the previous inline UI.Macroscope summarized 496fde5.