Skip to content

fix(desktop): ensure all windows are destroyed before launching the NSIS installer during update process #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Mar 28, 2026
Merged

fix(desktop): ensure all windows are destroyed before launching the NSIS installer during update process #1461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9067f24
fix(desktop): ensure all windows are destroyed before launching the N…
Mar 27, 2026
cb20a2f
fix(desktop): refine window destruction logic before NSIS installer l…
Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/desktop/src/main.ts
View file
Open in desktop
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,11 @@ async function installDownloadedUpdate(): Promise<{ accepted: boolean; completed
clearUpdatePollTimer();
try {
await stopBackendAndWaitForExit();
autoUpdater.quitAndInstall();
// Destroy all windows before launching the NSIS installer
for (const win of BrowserWindow.getAllWindows()) {
win.destroy();
}
autoUpdater.quitAndInstall(true, true);
return { accepted: true, completed: true };
} catch (error: unknown) {
const message = formatErrorMessage(error);
Expand Down