refactor: standardize server logging#1119
Open
Ivorisnoob wants to merge 10 commits intopingdotgg:mainfrom
Open
refactor: standardize server logging#1119Ivorisnoob wants to merge 10 commits intopingdotgg:mainfrom
Ivorisnoob wants to merge 10 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
consoletoEffect.log.Why
consoleare not captured by the project'srotating file sink. This change ensures critical provider events are persisted to disk.
patterns used by the Git and Terminal services.
UI Changes
N/A
Checklist
Note
Standardize logging in
CodexAppServerManager.startSessionto use Effect-based structured logsReplaces
console.logcalls instartSessionwith Effect'slogInfo/logWarningformodel/listandaccount/readrequests. Each log includes structured fields (e.g.response,cause,planType,sparkEnabled) and is awaited via.pipe(this.runPromise).Macroscope summarized 5685b8a.
Note
Low Risk
Low risk refactor that only changes how startup diagnostics are logged; behavior should be unchanged aside from structured log output and slight additional awaits during session startup.
Overview
Replaces
console.logdiagnostics inCodexAppServerManager.startSessionwith Effect-based structured logging.model/listandaccount/readsuccess paths now emitEffect.logInfowith structuredresponse/subscription fields, and failure paths emitEffect.logWarningwith a normalizedcause, all executed via.pipe(this.runPromise)so logs are captured by the configured sinks.Written by Cursor Bugbot for commit 5685b8a. This will update automatically on new commits. Configure here.