tiflash-proxy-next-gen: support encryption key rotation#10727
tiflash-proxy-next-gen: support encryption key rotation#10727ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThe pull request updates the submodule pointer for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bump tiflash-proxy-next-gen to the latest head of origin/tiflash-proxy-next-gen-9.0. This keeps TiFlash compatible with encryption config changes such as enabling CMEK or rotating data keys.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@contrib/tiflash-proxy-next-gen`:
- Line 1: The submodule gitlink was updated to commit
10e55dcd0867f44cc3503b2f23f477a034c37840 for contrib/tiflash-proxy-next-gen;
locally fetch and checkout that commit in the submodule, inspect the changes
(look for CMEK/key-rotation-related files and symbols such as any
kms/keyRotation functions or config keys), run the submodule's unit/integration
checks if available, and confirm the upstream repository's CI passed for that
commit (or obtain CI logs) before merging; if the commit is missing the expected
CMEK/key-rotation changes or CI failures appear, revert the gitlink update and
request the correct upstream commit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 19842147-b980-4fde-a74a-cee23f793764
📒 Files selected for processing (1)
contrib/tiflash-proxy-next-gen
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #10222
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit