coordinator: Support resume successfully when status have previous errors#3954
coordinator: Support resume successfully when status have previous errors#3954ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Conversation
Summary of ChangesHello @hongyunyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness of changefeed resume operations within the coordinator. It addresses a critical issue where changefeeds might fail to restart or immediately re-enter a problematic state due to lingering error information or an improperly initialized backoff mechanism from prior failures. By ensuring that resume attempts start with a clean, error-free status and a correctly reset internal state, the changes aim to provide a more reliable and predictable user experience for managing changefeeds. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to allow changefeeds to resume successfully even if they have previous errors in their status. The changes correctly implement this by creating a new function GetStatusForResume that provides a clean status without old errors. Additionally, there are good improvements in GC safepoint handling on resume failure and in resetting the backoff logic to prevent incorrect "stuck" state detection. However, I've found a critical issue where the checkpoint timestamp is not correctly updated when resuming a changefeed, which could lead to the changefeed starting from an incorrect position.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #3953
What is changed and how it works?
This pull request significantly enhances the robustness of changefeed resume operations within the coordinator. It addresses a critical issue where changefeeds might fail to restart or immediately re-enter a problematic state due to lingering error information or an improperly initialized backoff mechanism from prior failures. By ensuring that resume attempts start with a clean, error-free status and a correctly reset internal state, the changes aim to provide a more reliable and predictable user experience for managing changefeeds.
Highlights
GetStatusForResume, has been introduced which provides a deep copy of the changefeed status but explicitly excludes any historical running errors, ensuring a clean state for resume attempts.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note