fix(ddl): wait running add index before CREATE TABLE LIKE by wlwilliamx · Pull Request #3863 · pingcap/ticdc

wlwilliamx · 2025-12-31T09:55:35Z

What problem does this PR solve?

Issue Number: close #3832

What is changed and how it works?

Fix downstream schema inconsistency for CREATE TABLE ... LIKE ... when the referenced table has a long-running ADD INDEX that is still running/queueing in downstream TiDB. In this case, CREATE TABLE b LIKE a may copy the current downstream schema of a before the index becomes visible, causing b to miss the index.

This PR makes CREATE TABLE ... LIKE ... wait for any running async ADD INDEX on the referenced table before executing the CREATE TABLE ... LIKE ....

Detect CREATE TABLE ... LIKE ... in schemastore when building DDLEvent, extract the referenced table, and populate BlockedTableNames with that referenced table.
Adjust mysql/TiDB sink behavior so CREATE TABLE is eligible for async-DDL waiting logic; for normal create table (no LIKE), this is a no-op because BlockedTableNames is empty. For CREATE TABLE ... LIKE ..., it triggers waiting on the referenced table’s running ADD INDEX job.

Check List

Tests

Unit test
Integration test
Manual test

Questions

Will it cause performance regression or break compatibility?

None

Do you need to update user documentation, design documentation or monitoring documentation?

None

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

gemini-code-assist · 2025-12-31T09:55:52Z

Summary of Changes

Hello @wlwilliamx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical schema consistency problem in TiCDC where a CREATE TABLE ... LIKE ... statement might not correctly replicate the schema of a source table if that source table is undergoing an asynchronous ADD INDEX operation. The changes ensure that such CREATE TABLE operations will now pause and wait for any in-progress index additions on the referenced table to complete, guaranteeing that the newly created table accurately reflects the complete schema, including all indexes, of its source. This prevents potential data integrity issues and ensures reliable schema replication.

Highlights

Schema Inconsistency Fix: Resolves an issue where CREATE TABLE ... LIKE ... could lead to schema inconsistencies if the referenced table had a long-running ADD INDEX operation that was not yet visible.
Referenced Table Detection: Implements logic to detect CREATE TABLE ... LIKE ... statements, identify the referenced table, and populate BlockedTableNames in the DDL event to trigger waiting.
Async DDL Waiting for CREATE TABLE: Modifies the sink behavior to allow CREATE TABLE statements (specifically CREATE TABLE ... LIKE ... when a referenced table is blocked) to wait for pending async DDL operations on the referenced table.
Integration Test Enhancement: Adds an integration test to validate that CREATE TABLE ... LIKE ... correctly waits for and inherits indexes from the source table, ensuring the fix works as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively addresses the schema inconsistency issue with CREATE TABLE ... LIKE ... by ensuring it waits for any ongoing ADD INDEX operations on the referenced table. The approach of identifying the referenced table in the schemastore and adjusting the sink's waiting logic is sound. The changes are well-supported by both unit and integration tests, which provides good confidence in the fix. I have one minor suggestion to improve code readability.

wlwilliamx · 2025-12-31T10:20:05Z

/retest

wlwilliamx · 2025-12-31T10:20:15Z

/test all

wlwilliamx · 2026-01-04T16:05:18Z

/test all

wlwilliamx · 2026-01-05T04:45:18Z

/test pull-cdc-mysql-integration-light

wlwilliamx · 2026-01-05T04:45:24Z

/test pull-cdc-mysql-integration-heavy

wlwilliamx · 2026-01-05T08:32:12Z

/test all

wlwilliamx · 2026-01-05T10:44:00Z

/retest

wlwilliamx · 2026-01-06T08:11:43Z

/test all

wlwilliamx · 2026-01-06T12:02:28Z

/retest

wlwilliamx · 2026-01-06T13:50:48Z

/retest

wlwilliamx · 2026-01-07T03:11:40Z

/retest

wlwilliamx · 2026-01-07T07:11:25Z

/retest

wk989898 · 2026-01-07T08:07:11Z


 func needWaitAsyncExecDone(t timodel.ActionType) bool {
 	switch t {
-	case timodel.ActionCreateTable, timodel.ActionCreateTables:


I think it is not a good idea to remove this. If there are lots of create table DDL, every table will query the downstream. It may affect performance. Could we handle the create table like separately?

Removing create table and create tables here is irrelevant, because only create table like will have blocked table names. Only when there are blocked table names will the query add index and wait.

Why we could remove this function?

wlwilliamx · 2026-01-07T10:13:12Z

/test pull-cdc-mysql-integration-light

wlwilliamx · 2026-01-07T10:13:33Z

/test pull-cdc-mysql-integration-heavy

ti-chi-bot · 2026-01-12T09:38:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lidezhu,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-01-12T09:38:53Z

[LGTM Timeline notifier]

Timeline:

2026-01-07 10:23:12.125340515 +0000 UTC m=+784147.943648957: ☑️ agreed by wk989898.
2026-01-12 09:38:52.811763458 +0000 UTC m=+263976.873628368: ☑️ agreed by lidezhu.

wlwilliamx · 2026-01-13T08:18:46Z

/override pull-cdc-kafka-integration-heavy

ti-chi-bot · 2026-01-13T08:18:50Z

@wlwilliamx: Overrode contexts on behalf of wlwilliamx: pull-cdc-kafka-integration-heavy

Details

In response to this:

/override pull-cdc-kafka-integration-heavy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* fix(ddl): fix create table like ddl don't wait add index * refactor ut * modify error handle * refactor * set BlockedTables for create table like ddl * make check * fix extract refer table info * fix test query * remove the useless func needWaitAsyncExecDone * modify search name with case sensitive

* fix(ddl): fix create table like ddl don't wait add index * refactor ut * modify error handle * refactor * set BlockedTables for create table like ddl * make check * fix extract refer table info * fix test query * remove the useless func needWaitAsyncExecDone * modify search name with case sensitive (cherry picked from commit 5dfe293) Signed-off-by: tenfyzhong <tenfy@tenfy.cn>

* fix(ddl): fix create table like ddl don't wait add index * refactor ut * modify error handle * refactor * set BlockedTables for create table like ddl * make check * fix extract refer table info * fix test query * remove the useless func needWaitAsyncExecDone * modify search name with case sensitive

wlwilliamx added 3 commits December 31, 2025 16:34

fix(ddl): fix create table like ddl don't wait add index

9578eda

refactor ut

0e7dfa5

modify error handle

24b93c6

ti-chi-bot Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 31, 2025

wlwilliamx requested a review from lidezhu December 31, 2025 09:55

ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 31, 2025

wlwilliamx changed the title ~~Fix/create table like dont wait add index~~ fix(ddl): wait running add index before CREATE TABLE LIKE Dec 31, 2025

gemini-code-assist Bot reviewed Dec 31, 2025

View reviewed changes

Comment thread logservice/schemastore/persist_storage_ddl_handlers.go

refactor

318ea9b

set BlockedTables for create table like ddl

fd91573

ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2026

make check

faec49d

fix extract refer table info

188aa33

fix test query

9522880

wk989898 reviewed Jan 7, 2026

View reviewed changes

remove the useless func needWaitAsyncExecDone

271efc6

wk989898 approved these changes Jan 7, 2026

View reviewed changes

Comment thread logservice/schemastore/persist_storage_ddl_handlers.go Outdated

ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 7, 2026

modify search name with case sensitive

2a1d113

lidezhu reviewed Jan 10, 2026

View reviewed changes

Comment thread logservice/schemastore/persist_storage_test.go

lidezhu approved these changes Jan 12, 2026

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 12, 2026

wlwilliamx merged commit 5dfe293 into pingcap:master Jan 13, 2026
19 checks passed

wlwilliamx mentioned this pull request Jan 21, 2026

CREATE TABLE LIKE should wait for ADD INDEX #3631

Closed

Conversation

wlwilliamx commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Uh oh!

gemini-code-assist Bot commented Dec 31, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

wlwilliamx commented Dec 31, 2025

Uh oh!

wlwilliamx commented Dec 31, 2025

Uh oh!

wlwilliamx commented Jan 4, 2026

Uh oh!

wlwilliamx commented Jan 5, 2026

Uh oh!

wlwilliamx commented Jan 5, 2026

Uh oh!

wlwilliamx commented Jan 5, 2026

Uh oh!

wlwilliamx commented Jan 5, 2026

Uh oh!

wlwilliamx commented Jan 6, 2026

Uh oh!

wlwilliamx commented Jan 6, 2026

Uh oh!

wlwilliamx commented Jan 6, 2026

Uh oh!

wlwilliamx commented Jan 7, 2026

Uh oh!

wlwilliamx commented Jan 7, 2026

Uh oh!

wk989898 Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

wlwilliamx Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

hongyunyan Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

wlwilliamx commented Jan 7, 2026

Uh oh!

wlwilliamx commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot Bot commented Jan 12, 2026

Uh oh!

ti-chi-bot Bot commented Jan 12, 2026

[LGTM Timeline notifier]

Uh oh!

wlwilliamx commented Jan 13, 2026

Uh oh!

ti-chi-bot Bot commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wlwilliamx commented Dec 31, 2025 •

edited

Loading