Skip to content

system-variable: the value of ‘tidb_service_scope’ becomes case-insensitive in v9.0.0 and v8.5.6#22545

Open
Frank945946 wants to merge 2 commits intopingcap:masterfrom
Frank945946:patch-23
Open

system-variable: the value of ‘tidb_service_scope’ becomes case-insensitive in v9.0.0 and v8.5.6#22545
Frank945946 wants to merge 2 commits intopingcap:masterfrom
Frank945946:patch-23

Conversation

@Frank945946
Copy link
Collaborator

@Frank945946 Frank945946 commented Mar 9, 2026

First-time contributors' checklist

Update system-variable of ‘tidb_service_scope’

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Mar 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation for the tidb_service_scope system variable, providing important details about its case-insensitivity behavior. This ensures that users have precise and up-to-date information for configuring this variable, which is critical for the TiDB Distributed eXecution Framework (DXF).

Highlights

  • Documentation Update for tidb_service_scope: The documentation for the tidb_service_scope system variable has been updated to clarify that its value is case-insensitive since TiDB v8.5.6. The system now converts the input value to lowercase for storage and comparison.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • system-variables.md
    • Added a note indicating that the tidb_service_scope system variable is case-insensitive since v8.5.6 and is converted to lowercase for storage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the tidb_service_scope system variable to note that its value has become case-insensitive since v8.5.6. My review found a minor typo in the added description, which I've corrected with a suggestion.

Note: Security Review has been skipped due to the limited scope of the PR.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hfxsd hfxsd self-assigned this Mar 16, 2026
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. for-release This PR relates to a TiDB release but does not have a tracked feature. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed missing-translation-status This PR does not have translation status info. labels Mar 16, 2026
@hfxsd hfxsd changed the title Update system-variable of ‘tidb_service_scope’ system-variable: the value of ‘tidb_service_scope’ becomes case-insensitive in v9.0.0 and v8.5.6 Mar 16, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 16, 2026

@Frank945946: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify e34f94a link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hfxsd hfxsd self-requested a review March 16, 2026 08:41
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 16, 2026

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd requested a review from lilin90 March 19, 2026 09:27
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 19, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-19 09:27:55.922039743 +0000 UTC m=+435603.009697300: ☑️ agreed by hfxsd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. for-release This PR relates to a TiDB release but does not have a tracked feature. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants