Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Data Migration (DM) documentation by updating details on foreign key compatibility and integrating explicit requirements for MySQL's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates documentation related to TiDB Data Migration (DM), primarily to clarify foreign key support and add information about binlog transaction compression. The changes correctly reflect that foreign keys are 'not fully supported' rather than 'not supported', and consistently add the binlog_transaction_compression=OFF requirement across relevant documents. The changes are well-aligned with the stated goals. I have one minor suggestion for stylistic consistency.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Synced from: pingcap/docs#22543 Target PR: pingcap#21420 AI Provider: gemini Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
alastori
left a comment
There was a problem hiding this comment.
Thanks for the binlog transaction compression additions — those are solid and well-placed across precheck + Cloud migration guide.
Two suggestions on the FK wording and a consistency nit. Context: TiDB fully supports foreign keys (GA since v8.5.0). The limitation is DM's replication behavior, not TiDB's FK support. There's an open issue tiflow#12129 specifically about the misleading DM warning message, and active engineering work on DM FK support this week (tiflow#12552, tiflow#12541, tiflow#12414). The compatibility catalog already correctly frames this as a DM limitation, not a TiDB limitation.
| - Compatibility of the upstream MySQL table schema | ||
|
|
||
| - Check whether the upstream tables have foreign keys, which are not supported by TiDB. A warning is returned if a foreign key is found in the precheck. | ||
| - Check whether the upstream tables have foreign keys, which are not fully supported by TiDB. A warning is returned if a foreign key is found in the precheck. |
There was a problem hiding this comment.
TiDB fully supports foreign keys (GA since v8.5.0). The issue is that DM doesn't replicate CASCADE operations correctly — it sets foreign_key_checks=OFF during replication. Saying "not fully supported by TiDB" misattributes the limitation. This aligns with the existing Incompatibility with foreign key CASCADE operations section in the compatibility catalog.
See also: tiflow#12129 (update misleading warning message).
| - Check whether the upstream tables have foreign keys, which are not fully supported by TiDB. A warning is returned if a foreign key is found in the precheck. | |
| - Check whether the upstream tables have foreign keys. DM does not replicate foreign key CASCADE operations (see [Incompatibility with foreign key CASCADE operations](/dm/dm-compatibility-catalog.md#incompatibility-with-foreign-key-cascade-operations)). A warning is returned if a foreign key is found in the precheck. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?