fix(skillinject): reject path-traversal in plugin file names (PILOT-250)#6
Merged
Merged
Conversation
reconcilePluginFiles computes dst := filepath.Join(installDir, pf.Name) where pf.Name comes from the remote manifest. A malicious name like "../../.ssh/authorized_keys" would escape installDir and write outside the plugin sandbox. Add filepath.Clean + strings.HasPrefix guard that rejects traversal sequences before fetching or writing. Verified: build + vet + test all green. New test exercises both the rejection and happy path for non-traversal names. Closes PILOT-250
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
reconcilePluginFilesatskillinject.go:264joinsinstallDirwithpf.Namefrom the remote manifest without validating the resulting path stays insideinstallDir. A malicious manifest with"name": "../../.ssh/authorized_keys"would write outside the plugin sandbox.Why this fix
Added
filepath.Clean+strings.HasPrefixguard that rejects traversal sequences before fetching or writing. Mirrors the standard Go filesystem defense pattern.Verification
go build ./...— cleango vet ./...— cleango test ./...— all tests pass (including newTestReconcilePluginFiles_PathTraversalRejected)Files changed
skillinject.go: +10 (path-traversal guard + strings import)zz_extra_branches_test.go: +55 (new test)Closes PILOT-250