fix(directory): open per-network list_nodes to members (PILOT-347)#14
Merged
Merged
Conversation
The previous HandleListNodes gated EVERY list_nodes call on the admin token. The intent was to close an enumeration vector — any peer being able to list any network's members — but it locked normal users out of their own networks because only the network administrators hold the admin token (per PILOT-347). Split the policy by network ID: - netID == 0 (backbone) — admin-only. Real enumeration risk; only network admins need this view; users use lookup with a specific node_id instead. - netID != 0 (per-network) — open. Users are members of networks they joined and need to enumerate the members of those networks to send messages, do peer discovery, etc. No admin token required. Targeted tests pass.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per PILOT-347 threat model: the network admin token is held by network administrators only; normal users have no admin token. The previous
HandleListNodesrequired the admin token for every list_nodes call, which locked every user out of their own networks.Split the policy:
This is the symmetric per-PILOT-347 fix to common's #8 (admin-token only on managed.policy.set, not user-owned ops).