fix: gateway privilege check before loopback alias commands (PILOT-91)#3
Merged
Merged
Conversation
…OT-91) startProxy() now verifies process privileges before attempting to install loopback aliases via ip/ifconfig. When running as non-root the gateway previously logged an error but continued as if setup succeeded — subsequent connects failed in mysterious ways because no alias was actually installed. Changes: - Add loopbackPrivilegeCheck (euid gate, overridable in tests) - startProxy() bails out with a clear error if either the privilege check or the actual alias command fails - addLoopbackAlias() now returns error instead of silently logging - Tests bypass the privilege gate where they use exec stubs Closes PILOT-91
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
startProxy()now verifies process privileges before attempting to install loopback aliases viaip/ifconfig. Previously the gateway logged an error but continued as if setup succeeded — subsequent connects failed in mysterious ways because no alias was actually installed.Why
When the gateway runs as a non-root user,
ip addr add/ifconfig lo0 aliasfail with permission errors. The gateway silently ignored these failures, leading to hard-to-diagnose connection issues downstream.Changes
loopbackPrivilegeCheck(euid gate, overridable in tests).startProxy()bails out with a clear error if either the privilege check or the actual alias command fails.addLoopbackAlias()now returnserrorinstead of silently logging — the caller decides how to surface the failure.addLoopbackAlias.Verification
Closes PILOT-91