feat(daemonapi): Connection.Info() + Listener/PortAllocator/TunnelRegistry interfaces#4
Merged
Conversation
…lRegistry interfaces Phase 5: add the missing interfaces plugins need to fully decouple from web4/pkg/daemon. The previous v0.3.0 release left these as opaque markers; with v0.4.0 they have the methods runtime and libpilot actually call. Connection.Info() returns a ConnectionInfo struct containing the four endpoint quantities — LocalAddr, LocalPort, RemoteAddr, RemotePort. Using a struct snapshot avoids the Go-impossible name collision between the concrete *daemon.Connection's exported struct fields and same-named interface methods. Listener gains Accept + Port + Close so runtime/streams.go can drive a server loop without holding the concrete *daemon.Listener. PortAllocator.Bind / Unbind expose the daemon's port table. TunnelRegistry.RemovePeer lets handshake's revoke path tear down per-peer tunnel state without importing the concrete tunnel manager type. This is additive — every existing user of the v0.3.0 interfaces still compiles.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the four missing interfaces plugins need to fully decouple from web4/pkg/daemon. v0.3.0 left them as opaque markers; v0.4.0 gives them the methods runtime+libpilot actually call.
Connection.Info() ConnectionInfo— snapshot struct of LocalAddr/LocalPort/RemoteAddr/RemotePort. Struct return avoids Go's field/method name-collision on the concrete *daemon.Connection.Listener— Accept + Port + Close for plugin server loops.PortAllocator— Bind + Unbind.TunnelRegistry— RemovePeer.Additive; v0.3.0 callers still compile.
🤖 Generated with Claude Code