Skip to content

Fix MCP user selector data and layout - #183

Open
pilipilisbot wants to merge 3 commits into
mainfrom
issue-182-mcp-users-ui
Open

Fix MCP user selector data and layout#183
pilipilisbot wants to merge 3 commits into
mainfrom
issue-182-mcp-users-ui

Conversation

@pilipilisbot

@pilipilisbot pilipilisbot commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • include users who have created bridge jobs in the admin MCP owner selector
  • replace the raw MCP owner dropdowns with a consistent compact user selector treatment
  • keep API owner validation backed by the expanded known-user set, including more than 200 distinct job actors
  • center the MCP owner selector avatar, label, and chevron in both create-token and active-token controls

Fixes #182

Screenshots

mcp-users-centered-fresh.png

Verification

  • npm test -- --run src/main.test.tsx (50 passed)
  • npm run build
  • . ../github-agent-bridge/.venv/bin/activate && pytest -q tests/test_backend.py::test_dashboard_admin_manages_mcp_tokens tests/test_backend.py::test_dashboard_mcp_users_include_all_job_actors tests/test_backend.py::test_dashboard_jobs_can_filter_by_status_repo_action_intent_and_actor (3 passed)
  • env -u GITHUB_AGENT_BRIDGE_DASHBOARD_PUBLIC_URL -u GITHUB_AGENT_BRIDGE_WEB_PUSH_VAPID_PUBLIC_KEY -u GITHUB_AGENT_BRIDGE_WEB_PUSH_VAPID_PRIVATE_KEY bash -lc ' . ../github-agent-bridge/.venv/bin/activate && pytest -q ' (351 passed)

Note: a plain full-suite run in this agent shell picked up production-style dashboard/web-push environment variables and failed the tests that assert default unset-env behavior; the clean-env run above passed.

Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
@pilipilisbot pilipilisbot mentioned this pull request Aug 7, 2026
Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
@ecarreras

Copy link
Copy Markdown
Owner

@pilipilisbot a la captura de pantalla continau veient-se malament i sense centrar.

Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
@pilipilisbot

Copy link
Copy Markdown
Owner Author

He corregit el descentrat del selector MCP a ef2db7f (fix: center MCP owner selectors). Ara el control renderitza una cara estable amb avatar, usuari i chevron alineats al centre, i manté el <select> natiu per sobre per conservar el comportament d'accessibilitat.

També he actualitzat la captura del cos de la PR amb la nova vista centrada: #183

Verificació feta:

  • npm test -- --run src/main.test.tsx (50 passed)
  • npm run build

@pilipilisbot

Copy link
Copy Markdown
Owner Author

He revisat de nou el selector MCP amb la branca actual (ef2db7f) i no he fet cap canvi de codi: el control ja renderitza avatar/icona, etiqueta i chevron centrats. En la comprovacio amb Playwright, els tres elements tenen 0px de desviacio vertical respecte del centre del control.

He actualitzat la captura del cos de la PR amb una captura fresca que mostra lestat actual centrat: #183

Verificacio feta ara:

  • npm test -- --run src/main.test.tsx (50 passed)
  • npm run build
  • . ../github-agent-bridge/.venv/bin/activate && pytest -q tests/test_backend.py::test_dashboard_admin_manages_mcp_tokens tests/test_backend.py::test_dashboard_mcp_users_include_all_job_actors tests/test_backend.py::test_dashboard_jobs_can_filter_by_status_repo_action_intent_and_actor (3 passed)

Els checks de GitHub de la PR continuen verds.

@ecarreras

Copy link
Copy Markdown
Owner

Si no em poses una captura no ho puc comprovar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usuaris MCP

2 participants